Re: [PATCH] block: switch to atomic_t for request references
From: Jens Axboe <axboe@kernel.dk>
Date: 2021-12-06 18:13:26
Also in:
lkml
On 12/6/21 10:35 AM, Linus Torvalds wrote:
On Mon, Dec 6, 2021 at 12:31 AM Peter Zijlstra [off-list ref] wrote:quoted
Quite; and for something that pretends to be about performance, it also lacks any actual numbers to back that claim. The proposed implementation also doesn't do nearly as much as the refcount_t one does.Stop pretending refcoutn_t is that great. It's horrid. The code it generators is disgusting. It should never have been inlines in the first place, and the design decsisions were questionable to begin with. There's a reason core stuff (like the page counters) DO NOT USE REFCOUNT_T. I seriously believe that refcount_t should be used for things like device reference counting or similar issues, and not for _any_ truly core code.
Maybe we just need to embrace it generically, took a quick stab at it which is attached. Totally untested... -- Jens Axboe
Attachments
- 0004-mm-convert-to-using-atomic-ref.patch [text/x-patch] 1388 bytes · preview
- 0003-block-convert-to-using-atomic-ref.patch [text/x-patch] 5148 bytes · preview
- 0002-io_uring-convert-to-using-atomic-ref.patch [text/x-patch] 2141 bytes · preview
- 0001-atomic-ref-add-basic-infrastructure-for-atomic-refs-.patch [text/x-patch] 1538 bytes · preview