Thread (12 messages) 12 messages, 2 authors, 2021-08-06

Re: [PATCH v2 4/4] block: fix default IO priority handling

From: Hannes Reinecke <hare@suse.de>
Date: 2021-08-06 06:39:31
Also in: linux-f2fs-devel

On 8/6/21 7:11 AM, Damien Le Moal wrote:
The default IO priority is the best effort (BE) class with the
normal priority level IOPRIO_NORM (4). However, get_task_ioprio()
returns IOPRIO_CLASS_NONE/IOPRIO_NORM as the default priority and
get_current_ioprio() returns IOPRIO_CLASS_NONE/0. Let's be consistent
with the defined default and have both of these functions return the
default priority IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, IOPRIO_NORM) when
the user did not define another default IO priority for the task.

In include/linux/ioprio.h, rename the IOPRIO_NORM macro to
IOPRIO_BE_NORM to clarify that this default level applies to the BE
priotity class. Also, define the macro IOPRIO_DEFAULT as
IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, IOPRIO_BE_NORM) and use this new
macro when setting a priority to the default.

Signed-off-by: Damien Le Moal <redacted>
---
  block/bfq-iosched.c          | 2 +-
  block/ioprio.c               | 6 +++---
  drivers/nvme/host/lightnvm.c | 2 +-
  include/linux/ioprio.h       | 7 ++++++-
  include/uapi/linux/ioprio.h  | 4 ++--
  5 files changed, 13 insertions(+), 8 deletions(-)
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help