Re: [PATCH 1/2] block: bio: ensure newly added bio flags don't override BVEC_POOL_IDX
From: Hannes Reinecke <hare@suse.de>
Date: 2019-03-21 15:54:37
Also in:
linux-fsdevel
On 3/21/19 3:25 PM, Jens Axboe wrote:
On 3/21/19 8:23 AM, Johannes Thumshirn wrote:quoted
On 21/03/2019 15:21, Jens Axboe wrote:quoted
On 3/21/19 8:15 AM, Jens Axboe wrote:quoted
You also haven't solved the issue of now having an extra bit, 2/2 uses the last bit which the other patch already took...Here's one way - kill BIO_SEG_VALID. We should just use ->bi_phys_segments to tell if it's valid or not. This patch uses -1 to signify it's not. Totally untested...That sounds like an idea, I'll trow some testing at it and report back.That'd be great, thanks. If we can do that as a prep patch for you, then you can just use an enum and not worry about initializing since I'll just shove BIO_PAGE_NO_REF at the end. And this is simpler than having to shift the masks around.
And it would also remove the possiblity that SEG_VALID and nr_phys_segments get out of sync. We still have some unresolved issues revolving around this problem... So yeah, I do like it, too. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)