On 3/21/19 8:23 AM, Johannes Thumshirn wrote:

On 21/03/2019 15:21, Jens Axboe wrote:

quoted

On 3/21/19 8:15 AM, Jens Axboe wrote:

quoted

You also haven't solved the issue of now having an extra bit, 2/2 uses
the last bit which the other patch already took...

Here's one way - kill BIO_SEG_VALID. We should just use
->bi_phys_segments to tell if it's valid or not. This patch uses -1 to
signify it's not.

Totally untested...

That sounds like an idea, I'll trow some testing at it and report back.

That'd be great, thanks. If we can do that as a prep patch for you, then
you can just use an enum and not worry about initializing since I'll just
shove BIO_PAGE_NO_REF at the end.

And this is simpler than having to shift the masks around.

-- 
Jens Axboe