Thread (11 messages) 11 messages, 4 authors, 2019-03-22

Re: [PATCH 1/2] block: bio: ensure newly added bio flags don't override BVEC_POOL_IDX

From: Johannes Thumshirn <hidden>
Date: 2019-03-21 13:22:29
Also in: linux-fsdevel

On 21/03/2019 14:18, Hannes Reinecke wrote:
Where's the point of the enum if all values are initialized?
Enums start at 0 if not otherwise initialized and I wanted to keep the
unused 0th bit as unused in this patch, for either the patch from Jens
or 2/2 in this series.

It's the only reason and it is not wrong to do and not the only place
where we have it:

jthumshirn@glass:linux (master)$ git grep -A 1 "enum {" | grep "= 0" | wc -l
2206

-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help