Thread (64 messages) 64 messages, 5 authors, 2019-02-11

Re: [PATCH v4 02/16] block: sed-opal: use correct macro for method length

From: Derrick, Jonathan <hidden>
Date: 2019-02-08 22:56:57
Also in: lkml

Looks good

Reviewed-by: Jon Derrick <redacted>

On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote:
quoted hunk ↗ jump to hunk
From: Jonas Rabenstein <redacted>

Also the values of OPAL_UID_LENGTH and OPAL_METHOD_LENGTH are the same,
it is weird to use OPAL_UID_LENGTH for the definition of the methods.

Signed-off-by: Jonas Rabenstein <redacted>
Reviewed-by: Scott Bauer <redacted>
---
 block/sed-opal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/sed-opal.c b/block/sed-opal.c
index c882a193e162..5c123a5b4ab1 100644
--- a/block/sed-opal.c
+++ b/block/sed-opal.c
@@ -181,7 +181,7 @@ static const u8 opaluid[][OPAL_UID_LENGTH] = {
  * Derived from: TCG_Storage_Architecture_Core_Spec_v2.01_r1.00
  * Section: 6.3 Assigned UIDs
  */
-static const u8 opalmethod[][OPAL_UID_LENGTH] = {
+static const u8 opalmethod[][OPAL_METHOD_LENGTH] = {
 	[OPAL_PROPERTIES] =
 		{ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x01 },
 	[OPAL_STARTSESSION] =

Attachments

  • smime.p7s [application/x-pkcs7-signature] 3278 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help