On Tue, Feb 05, 2019 at 12:06:54AM +0100, David Kozub wrote:

This will unfortunately trigger some changes (conflict resolving - e.g. if I
move the last two patches in the current series forward, in front of the
patches with new functionality). What is the proper procedure w.r.t.
Reviewed-by tags which were already given? Common sense would make me keep
them for trivial changes and remove them if the patch should be re-reviewed.
Is that correct?

I don't think there is a general rule.  As long as the change is trivial
I keep them personally, otherwise I drop them.

E.g. if you just remove a few hunk because of new code that isn't
present now I'd keep them, if there are more complex changes to the code
flow I would consider dropping them.

FWIW I also hacked together a tool to cover my usecase:
https://gitlab.com/zub2/opalctl

The selling point is that it can handle passwords the same way that sedutil
(https://github.com/Drive-Trust-Alliance/sedutil) does.

That actually is pretty nice, as it allows people to migrate over
(not that I've heard of a whole lot of usage of sedutil, but being
compatible to some extent is always nice)