Thread (32 messages) 32 messages, 9 authors, 2018-02-08

RE: [PATCH V2 7/8] scsi: hpsa: call hpsa_hba_inquiry() after adding host

From: Don Brace <hidden>
Date: 2018-02-05 18:55:11
Also in: linux-scsi

-----Original Message-----
From: Ming Lei [mailto:ming.lei@redhat.com]
Sent: Monday, February 05, 2018 9:21 AM
To: Jens Axboe <axboe@kernel.dk>; linux-block@vger.kernel.org; Christoph
Hellwig [off-list ref]; Mike Snitzer [off-list ref]
Cc: linux-scsi@vger.kernel.org; Hannes Reinecke <hare@suse.de>; Arun Easi
[off-list ref]; Omar Sandoval [off-list ref]; Martin K .
Petersen [off-list ref]; James Bottomley
[off-list ref]; Christoph Hellwig [off-list ref];
Don Brace [off-list ref]; Kashyap Desai
[off-list ref]; Peter Rivera [off-list ref];
Paolo Bonzini [off-list ref]; Laurence Oberman
[off-list ref]; Ming Lei [off-list ref]
Subject: [PATCH V2 7/8] scsi: hpsa: call hpsa_hba_inquiry() after adding =
host
quoted hunk ↗ jump to hunk
=20
EXTERNAL EMAIL
=20
=20
So that we can decide the default reply queue by the map created
during adding host.
=20
Cc: Hannes Reinecke <hare@suse.de>
Cc: Arun Easi <redacted>
Cc: Omar Sandoval <redacted>,
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Cc: James Bottomley <james.bottomley@hansenpartnership.com>,
Cc: Christoph Hellwig <hch@lst.de>,
Cc: Don Brace <redacted>
Cc: Kashyap Desai <kashyap.desai@broadcom.com>
Cc: Peter Rivera <redacted>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Mike Snitzer <redacted>
Tested-by: Laurence Oberman <redacted>
Signed-off-by: Ming Lei <redacted>
---
 drivers/scsi/hpsa.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
=20
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 287e5eb0723f..443eabf63a9f 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -8691,12 +8691,9 @@ static int hpsa_init_one(struct pci_dev *pdev, con=
st
struct pci_device_id *ent)
        /* Disable discovery polling.*/
        h->discovery_polling =3D 0;
=20
-
        /* Turn the interrupts on so we can service requests */
        h->access.set_intr_mask(h, HPSA_INTR_ON);
=20
-       hpsa_hba_inquiry(h);
-
        h->lastlogicals =3D kzalloc(sizeof(*(h->lastlogicals)), GFP_KERNE=
L);
quoted hunk ↗ jump to hunk
        if (!h->lastlogicals)
                dev_info(&h->pdev->dev,
@@ -8707,6 +8704,8 @@ static int hpsa_init_one(struct pci_dev *pdev, cons=
t
struct pci_device_id *ent)
        if (rc)
                goto clean7; /* perf, sg, cmd, irq, shost, pci, lu, aer/h=
 */
=20
+       hpsa_hba_inquiry(h);
+
        /* Monitor the controller for firmware lockups */
        h->heartbeat_sample_interval =3D HEARTBEAT_SAMPLE_INTERVAL;
        INIT_DELAYED_WORK(&h->monitor_ctlr_work, hpsa_monitor_ctlr_worker=
);
--
2.9.5
Tested-by: Don Brace <redacted>
P441, P431, P830i, H240

Acked-by: Don Brace <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help