On Mon, 2017-03-20 at 16:43 -0400, Christoph Hellwig wrote:

+	case SD_LBP_ATA_TRIM:
+		max_blocks =3D 65535 * (512 / sizeof(__le64));
+		if (sdkp->device->ata_trim_zeroes_data)
+			q->limits.discard_zeroes_data =3D 1;
+		break;

Do we need a comment here that explains where the numbers 65535 and
512 come from?

+	u64 sector =3D blk_rq_pos(rq) >> (ilog2(sdp->sector_size) - 9);
+	u32 nr_sectors =3D blk_rq_sectors(rq) >> (ilog2(sdp->sector_size) - 9);

Please consider using logical_to_sectors() instead of open-coding this
function.

Thanks,

Bart.=