Hi Krzysztof

On 2/5/26 10:43 AM, Krzysztof Kozlowski wrote:

On 23/01/2026 09:09, Antoine Bouyer wrote:

quoted

Add dt-bindings for NXP neoisp module.

What is a neoisp module?

This is Image Signal Processing IP from NXP.
Indeed my commit msg was not well documented sorry :( Will add more info 
in future patchset.

quoted

Signed-off-by: Antoine Bouyer <redacted>
---
  .../devicetree/bindings/media/nxp,neoisp.yaml | 65 +++++++++++++++++++
  1 file changed, 65 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/media/nxp,neoisp.yaml

diff --git a/Documentation/devicetree/bindings/media/nxp,neoisp.yaml b/Documentation/devicetree/bindings/media/nxp,neoisp.yaml
new file mode 100644
index 000000000000..4dc9fa5a03b7
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/nxp,neoisp.yaml

@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/nxp,neoisp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP NEOISP Image Signal Processing Pipeline
+
+maintainers:
+  - Antoine Bouyer <antoine.bouyer@nxp.com>
+
+description:
+  The NXP NEOISP performs a set of image processing tasks on the RAW camera
+  stream and provides RGB or YUV enhanced image.
+
+properties:
+  compatible:
+    enum:
+      - nxp,neoisp

Please read writing bindings document.

quoted

+      - nxp,imx95-a0-neoisp
+      - nxp,imx95-a1-neoisp
+      - nxp,imx95-b0-neoisp

Nothing explains me why one SoC has three neoisp. You have entire commit
msg to explain weird things.

Actually, there are 2 ISP versions (v1, v2), and 3 i.MX95 versions a0, 
a1 and b0. ISP v1 is integrated into i.MX95 a0 and a1 versions, while 
ISP v2 is integrated into i.MX95 b0 only. v2 has some HW changes/fixes 
compared to v1 which are handled in the driver.

I kept exact SoC name in neo compatibles to avoid confusion.

However, since a0 and a1 are not targeted for production, but only b0, I 
will keep only one compatible: "nxp,imx95-neoisp". Will use same as file 
name.

quoted

+
+  reg:
+    items:
+      - description: The configuration registers
+      - description: ISP local memories
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    minItems: 1

maxItems. There is no such syntax like you wrote. Look at other code in
case of doubts.

Ok, I looked into other bindings before submitting of course, but missed 
it sorry. Will take care of it in next patchset.

BR
Antoine

quoted

+
+  clock-names:
+    items:
+      - const: camcm0
+
+  power-domains:
+    maxItems: 1
+

Best regards,
Krzysztof