Re: [RFC v1 05/11] dt-bindings: media: Add nxp neoisp support
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-02-05 09:43:48
Also in:
linux-devicetree, linux-media, lkml
On 23/01/2026 09:09, Antoine Bouyer wrote:
Add dt-bindings for NXP neoisp module.
What is a neoisp module?
quoted hunk ↗ jump to hunk
Signed-off-by: Antoine Bouyer <redacted> --- .../devicetree/bindings/media/nxp,neoisp.yaml | 65 +++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/nxp,neoisp.yamldiff --git a/Documentation/devicetree/bindings/media/nxp,neoisp.yaml b/Documentation/devicetree/bindings/media/nxp,neoisp.yaml new file mode 100644 index 000000000000..4dc9fa5a03b7 --- /dev/null +++ b/Documentation/devicetree/bindings/media/nxp,neoisp.yaml@@ -0,0 +1,65 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/nxp,neoisp.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP NEOISP Image Signal Processing Pipeline + +maintainers: + - Antoine Bouyer <antoine.bouyer@nxp.com> + +description: + The NXP NEOISP performs a set of image processing tasks on the RAW camera + stream and provides RGB or YUV enhanced image. + +properties: + compatible: + enum: + - nxp,neoisp
Please read writing bindings document.
+ - nxp,imx95-a0-neoisp + - nxp,imx95-a1-neoisp + - nxp,imx95-b0-neoisp
Nothing explains me why one SoC has three neoisp. You have entire commit msg to explain weird things.
+ + reg: + items: + - description: The configuration registers + - description: ISP local memories + + interrupts: + maxItems: 1 + + clocks: + minItems: 1
maxItems. There is no such syntax like you wrote. Look at other code in case of doubts.
+ + clock-names: + items: + - const: camcm0 + + power-domains: + maxItems: 1 +
Best regards, Krzysztof