Re: [RFC v1 08/11] media: uapi: Add NXP NEOISP user interface header file
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2026-02-09 23:29:13
Also in:
linux-devicetree, linux-media, lkml
On Fri, Jan 23, 2026 at 09:09:35AM +0100, Antoine Bouyer wrote:
quoted hunk ↗ jump to hunk
Add user space api header file for meta data structures definitions. This header describes `parameters` buffer for the ISP blocks control by userspace, and `statistics` buffer for userspace and IPA handling. These 2 buffers both support legacy and extensible modes. Legacy mode is a static fixed buffer structure, while extensible mode uses the v4l2-isp generic definitions to support various amount of ISP blocks. Parameters buffer uses v4l2-isp generic definitions, so as other ISP devices (rkisp1, mali-c55). Statistics buffer uses the newly introduced generic `v4l2_isp_stats_buffer`, which behaves the same as the generic `v4l2_isp_params_buffer`. Signed-off-by: Antoine Bouyer <redacted> --- include/uapi/linux/media/nxp/nxp_neoisp.h | 1968 +++++++++++++++++++++ 1 file changed, 1968 insertions(+) create mode 100644 include/uapi/linux/media/nxp/nxp_neoisp.hdiff --git a/include/uapi/linux/media/nxp/nxp_neoisp.h b/include/uapi/linux/media/nxp/nxp_neoisp.h new file mode 100644 index 000000000000..186973a1a6b2 --- /dev/null +++ b/include/uapi/linux/media/nxp/nxp_neoisp.h@@ -0,0 +1,1968 @@ +/* SPDX-License-Identifier: ((GPL-2.0+ WITH Linux-syscall-note) OR MIT) */ +/* + * NXP NEOISP userspace API + * + * Copyright 2023-2026 NXP + */ + +#ifndef __UAPI_NXP_NEOISP_H +#define __UAPI_NXP_NEOISP_H + +#include <linux/media/v4l2-isp.h> +#include <linux/types.h> +#include <linux/v4l2-controls.h> + +/* + * Check Documentation/admin-guide/media/nxp-neoisp.rst for control details. + */ +#define V4L2_CID_NEOISP_SUPPORTED_PARAMS_BLOCKS (V4L2_CID_USER_NEOISP_BASE + 1)
I wonder if we should turn this into a standard control, given that all ISPs will need it. Would a control to report the supported statistics block be useful too ? [snip] -- Regards, Laurent Pinchart