Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible

On 08/10/2025 13:45, Pritam Manohar Sutar wrote:

Hi Krzysztof,

quoted

-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: 07 October 2025 11:54 AM
To: Pritam Manohar Sutar <redacted>; vkoul@kernel.org;
kishon@kernel.org; robh@kernel.org; krzk+dt@kernel.org;
conor+dt@kernel.org; alim.akhtar@samsung.com; andre.draszik@linaro.org;
peter.griffin@linaro.org; kauschluss@disroot.org;
ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org;
m.szyprowski@samsung.com; s.nawrocki@samsung.com
Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux-
kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-
soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com;
faraz.ata@samsung.com; muhammed.ali@samsung.com;
selvarasu.g@samsung.com
Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
ExynosAutov920 HS phy compatible

On 22/09/2025 14:26, Pritam Manohar Sutar wrote:

quoted

This phy needs 0.75v, 0.18v and 3.3v supplies for its internal
functionally. Power Supply's names are as per phy's User Data-Book.
These names, (dvdd, vdd18 and vdd33), are considered  for 0.75v, 1.8v
and 3.3v respectively.
"

quoted

I still cannot find constraints for the rest of properties, though.

Sorry I didn't get it completely. Can you please elaborate on the same?

Writing bindings and introductory talks elaborate on that. You add properties
without constraints. That's not what we want. We want constraints.

Have added only supplies in this patch-set. However, was going 
through schema example and it says nothing is needed to define
in terms of supply. 

I don't have original patchset in my inbox anymore, so not sure what was
there, but most likely you miss constraining the presence of these
properties per each variant. IOW, not each of devices in the bindings
have these supplies, so I expect syntax similar as in example-schema.

https://elixir.bootlin.com/linux/v5.19/source/Documentation/devicetree/bindings/example-schema.yaml#L212


Best regards,
Krzysztof