Thread (29 messages) 29 messages, 3 authors, 2025-10-08

Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-09-18 02:43:27
Also in: linux-devicetree, linux-phy, linux-samsung-soc, lkml

On 04/09/2025 19:21, Pritam Manohar Sutar wrote:
Hi Krzysztof,
quoted
-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: 04 September 2025 03:12 PM
To: Pritam Manohar Sutar <redacted>
Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org;
krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com;
andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org;
ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org;
m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux-
phy@lists.infradead.org; devicetree@vger.kernel.org; linux-
kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-
soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com;
faraz.ata@samsung.com; muhammed.ali@samsung.com;
selvarasu.g@samsung.com
Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
ExynosAutov920 HS phy compatible

On 04/09/2025 09:51, Pritam Manohar Sutar wrote:
quoted
Hi Krzysztof,
quoted
-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: 04 September 2025 12:18 PM
To: Pritam Manohar Sutar <redacted>
Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org;
krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com;
andre.draszik@linaro.org; peter.griffin@linaro.org;
kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com;
igor.belwon@mentallysanemainliners.org;
m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux-
phy@lists.infradead.org; devicetree@vger.kernel.org; linux-
kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-samsung- soc@vger.kernel.org; rosa.pila@samsung.com;
dev.tailor@samsung.com; faraz.ata@samsung.com;
muhammed.ali@samsung.com; selvarasu.g@samsung.com
Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy:
add
ExynosAutov920 HS phy compatible

On Wed, Sep 03, 2025 at 01:08:22PM +0530, Pritam Manohar Sutar wrote:
quoted
Document support for the USB20 phy found on the ExynosAutov920 SoC.
The
USB20 phy is functionally identical to that on the Exynos850 SoC, so
no driver changes are needed to support this phy. However, add a
dedicated compatible string for USB20 phy found in this SoC.

Signed-off-by: Pritam Manohar Sutar <redacted>
You just dropped all tags without explaining why.
Regretted inconvenience.

There were significant changes in supplies' names in driver and
schemas (patch-set v8). This led to make changes in patch no 5.  And
review for these changes is needed.  Hence, removed RB tag in this patch-set.

There was a ask for the same https://lore.kernel.org/linux-
phy/000401dc18cd$ec02a1b0$c407e510$@samsung.com/#:~:text=Let%20me%
20know%2C%20because%20of%20above%20changes%2C%20should%20be%20
removing%20your%20%0A%27reviewed%2Dby%27%20tag%20from%20patch%
201%20and%203.
quoted

Where in the changelog you explained why you dropped the tags?
Along with supplies' names, there were similar commit messages 
for patch no 1, 3 as patch no 5 (v7). (though, they were explaining 
schema more than h/w). Changed commit messages of the 
patch no 1, 3, 5 (v7) as per reference commits and would like 
to get them reviewed again, so did not add RB for patch 1 and 3,
which you had given RB (in v7). 
I do not have time to review the same second time and I find such
request quite a waste of my time. It's v8 so I am surprised to see it
getting changed even after review.


Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help