Re: [PATCH 13/33] arm_mpam: Add MPAM MSC register layout definitions
From: James Morse <james.morse@arm.com>
Date: 2025-09-10 19:31:43
Also in:
linux-acpi, linux-devicetree, lkml
Hi Shaopeng, On 09/09/2025 12:36, Shaopeng Tan (Fujitsu) wrote:
quoted
Memory Partitioning and Monitoring (MPAM) has memory mapped devices (MSCs) with an identity/configuration page. Add the definitions for these registers as offset within the page(s).
quoted
diff --git a/drivers/resctrl/mpam_internal.h b/drivers/resctrl/mpam_internal.h index d49bb884b433..6e0982a1a9ac 100644 --- a/drivers/resctrl/mpam_internal.h +++ b/drivers/resctrl/mpam_internal.h@@ -150,4 +150,270 @@ extern struct list_head mpam_classes; int
quoted
+#define MSMON_CFG_MBWU_CTL_TYPE_MBWU 0x42 +#define MSMON_CFG_CSU_CTL_TYPE_CSU 0+#define MSMON_CFG_CSU_CTL_TYPE_CSU 0x43?
Yes, that looks like the line got truncated. This would have caused the counter type to be mismatched and reprogrammed each time. Thanks for spotting it! James