Thread (200 messages) 200 messages, 10 authors, 2025-09-10

Re: [PATCH 20/33] arm_mpam: Add a helper to touch an MSC from any CPU

From: James Morse <james.morse@arm.com>
Date: 2025-09-09 16:58:04
Also in: linux-acpi, linux-devicetree, lkml

Hi Ben,

On 28/08/2025 17:13, Ben Horgan wrote:
On 8/22/25 16:30, James Morse wrote:
quoted
Resetting RIS entries from the cpuhp callback is easy as the
callback occurs on the correct CPU. This won't be true for any other
caller that wants to reset or configure an MSC.

Add a helper that schedules the provided function if necessary.
Prevent the cpuhp callbacks from changing the MSC state by taking the
cpuhp lock.
At first, I thought this was referring to something done in the patch.
Consider changing to something like:

Callers should take the cpuhp lock to prevent the cpuhp callbacks from
changing the MSC state.
Yes - that is better,

Regardless, this looks good to me.

Reviewed-by: Ben Horgan <ben.horgan@arm.com>

Thanks!

James
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help