Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Firefly ROC-RK3588-RT

On Tue, 2025-09-09 at 09:22 +0200, Krzysztof Kozlowski wrote:

On Tue, Sep 09, 2025 at 09:31:47AM +0800, Kaison Deng wrote:

quoted

This documents Firefly ROC-RK3588-RT which is a SBC based on RK3588
SoC.

Link: https://en.t-firefly.com/product/industry/rocrk3588rt

Signed-off-by: Kaison Deng <redacted>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml

b/Documentation/devicetree/bindings/arm/rockchip.yaml
index f9ee77f17ad7..6aceaa8acbb2 100644

--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml

@@ -258,6 +258,11 @@ properties:
           - const: firefly,roc-rk3576-pc
           - const: rockchip,rk3576
 
+      - description: Firefly ROC-RK3588-RT
+        items:
+          - const: firefly,roc-rk3588-rt

That's just enum with ROC-RK3576-PC. BTW, all these descriptionis are
completely redundant. Actually getting harmful, because copy+paste of
the same is only obfuscating code.

Best regards,
Krzysztof

The ROC-RK3576-PC is based on the RK3576 SoC (4*Cortex-A72 + 4*Cortex-
A53). The ROC-RK3588-RT is based on the RK3588 SoC (4*Cortex-A76 +
4*Cortex-A55). They are two different miniature single-board computers.
So it does not apply to the enum with RK3576.

Link: https://en.t-firefly.com/product/industry/rocrk3576pc

Best regards,
Kaison