Re: [PATCH v2 2/2] arm64: dts: rockchip: Add devicetree for the ROC-RK3588-RT
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-09-09 12:31:50
Also in:
linux-devicetree, linux-rockchip, lkml
- 2x Gigabit Ethernet, 1x 2.5G Ethernet
I actually only see the 2x 1G. Is the 2.5G not supported yet?
quoted hunk ↗ jump to hunk
+&gmac0 { + clock_in_out = "output"; + phy-handle = <&rgmii_phy0>; + phy-mode = "rgmii-rxid"; + pinctrl-names = "default"; + pinctrl-0 = <&gmac0_miim + &gmac0_tx_bus2 + &gmac0_rx_bus2 + &gmac0_rgmii_clk + &gmac0_rgmii_bus>; + tx_delay = <0x47>;
What happened about my comment that "rgmii-rxid" is probably wrong? If you think it is correct, you should reply with a justification. Maybe PCB is very odd? In which case, a comment would be good to explain who it is odd. Andrew