Re: [PATCH 05/13] dt-bindings: soc: amlogic: Unify the compatible property for clk-measure
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-08-20 08:09:25
Also in:
linux-amlogic, linux-devicetree, lkml
On Fri, Aug 15, 2025 at 04:37:31PM +0800, Chuan Liu wrote:
quoted hunk ↗ jump to hunk
The clk-measure IPs across Amlogic SoCs have minimal differences, so they can be managed with a unified compatible property. Signed-off-by: Chuan Liu <redacted> --- .../bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml index 1c9d37eef5f0..a7927acde2fe 100644 --- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml@@ -15,15 +15,7 @@ maintainers: properties: compatible: - enum: - - amlogic,meson-gx-clk-measure - - amlogic,meson8-clk-measure - - amlogic,meson8b-clk-measure - - amlogic,meson-axg-clk-measure - - amlogic,meson-g12a-clk-measure - - amlogic,meson-sm1-clk-measure - - amlogic,c3-clk-measure - - amlogic,s4-clk-measure + const: amlogic,clk-measure
Obviously NAK, cannot stress more how wrong your approach is. It defies all rules for writing bindings. Best regards, Krzysztof