Re: [PATCH 01/13] dt-bindings: soc: amlogic: Add clk-measure related properties
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-08-20 08:08:53
Also in:
linux-amlogic, linux-devicetree, lkml
On Fri, Aug 15, 2025 at 04:37:27PM +0800, Chuan Liu wrote:
quoted hunk ↗ jump to hunk
Add three properties to clk-measure: 'clkmsr-indices', 'clkmsr-names', and 'clkmsr-reg-v2' for describing measurable channels and register offsets in DT. Signed-off-by: Chuan Liu <redacted> --- .../soc/amlogic/amlogic,meson-gx-clk-measure.yaml | 54 +++++++++++++++++++++- 1 file changed, 53 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml index 39d4637c2d08..1c9d37eef5f0 100644 --- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml@@ -6,7 +6,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: Amlogic Internal Clock Measurer -description: +description: |
Why?
quoted hunk ↗ jump to hunk
The Amlogic SoCs contains an IP to measure the internal clocks. The precision is multiple of MHz, useful to debug the clock states.@@ -28,15 +28,67 @@ properties: reg: maxItems: 1 + clkmsr-indices: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: |
Why | ?
+ Supported channel IDs for clk-measure. + minItems: 1 + maxItems: 256
Nothing - neither this nor commit msg - explains why you need it and what this is.
+ + clkmsr-names: + $ref: /schemas/types.yaml#/definitions/string-array + description: | + The channel ID names supported by clk-measure correspond one-to-one with + the IDs specified in 'clkmsr-indices'. + + Therefore, the defined 'clkmsr-indices' and 'clkmsr-names' must have + matching counts and maintain strict correspondence. + minItems: 1 + maxItems: 256 + + clkmsr-reg-v2: + type: boolean + description: | + Specify whether the register address offset for clk-measure corresponds + to version V2.
No, compatible defines this.
+ required: - compatible - reg + - clkmsr-indices + - clkmsr-names
That's ABI break. Again, nothing explains it. Best regards, Krzysztof