Re: [RESEND v3 5/5] PCI: dwc: Don't return error when wait for link up
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2025-08-18 15:32:26
Also in:
imx, linux-pci, lkml
On Mon, Aug 18, 2025 at 03:32:05PM +0800, Richard Zhu wrote:
When waiting for the PCIe link to come up, both link up and link down are valid results depending on the device state. Do not return an error, as the outcome has already been reported in dw_pcie_wait_for_link().
The reporting in dw_pcie_wait_for_link() is only a note in dmesg (and the -EDTIMEDOUT return, which we're throwing away here). We need an explanation here about why the caller of dw_pcie_resume_noirq() doesn't need to know whether the link came up. A short comment in the code would be useful as well.
quoted hunk ↗ jump to hunk
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> --- drivers/pci/controller/dwc/pcie-designware-host.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index 868e7db4e3381..e90fd34925702 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c@@ -1089,9 +1089,7 @@ int dw_pcie_resume_noirq(struct dw_pcie *pci) if (ret) return ret; - ret = dw_pcie_wait_for_link(pci); - if (ret) - return ret; + dw_pcie_wait_for_link(pci); return ret;
This should be "return 0" because if "ret" was non-zero, we returned that earlier.
} -- 2.37.1