Re: [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2025-08-04 07:59:40
Also in:
linux-clk, linux-devicetree, linux-gpio, linux-mediatek, linux-sound, lkml
Il 01/08/25 13:18, Julien Massot ha scritto:
quoted hunk ↗ jump to hunk
Update the mediatek,audsys binding to support the mt8183-audiosys compatible, which uses a different audio controller binding (mt8183-afe-pcm.yaml) compared to the legacy mt2701-audio controller. Signed-off-by: Julien Massot <julien.massot@collabora.com> --- .../bindings/arm/mediatek/mediatek,audsys.yaml | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml index 45d4a6620041b11cf6e943de49a42f3fcd91e1b9..5d9d91f9c5802240ac7d411c5632ae6663d15f29 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml@@ -23,6 +23,7 @@ properties: - mediatek,mt7622-audsys - mediatek,mt8167-audsys - mediatek,mt8173-audsys + - mediatek,mt8183-audiosys - mediatek,mt8183-audsys - mediatek,mt8186-audsys - mediatek,mt8192-audsys@@ -41,7 +42,6 @@ properties: const: 1 audio-controller: - $ref: /schemas/sound/mediatek,mt2701-audio.yaml# type: object required:@@ -50,6 +50,21 @@ required: additionalProperties: false +allOf:
I think you can do it without the allOf here as well.
if:
properties:
compatible:
contains...
then:
properties
...
else:
... etc
after which
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: mediatek,mt8183-audiosys
+ then:
+ properties:
+ audio-controller:
+ $ref: /schemas/sound/mt8183-afe-pcm.yaml#
+ else:
+ properties:
+ audio-controller:
+ $ref: /schemas/sound/mediatek,mt2701-audio.yaml#
+
examples:
- |
#include <dt-bindings/interrupt-controller/arm-gic.h>