[PATCH 9/9] arm64: dts: mediatek: mt8183-pumkin: Fix pull-down/up-adv values
From: Julien Massot <julien.massot@collabora.com>
Date: 2025-08-01 11:18:18
Also in:
linux-clk, linux-devicetree, linux-gpio, linux-mediatek, linux-sound, lkml
Subsystem:
arm/mediatek soc support, the rest · Maintainers:
Matthias Brugger, AngeloGioacchino Del Regno, Linus Torvalds
The properties `mediatek,pull-up-adv` and `mediatek,pull-down-adv` were using incorrect values like `<10>` and `<01>`. These values are parsed as decimal (10 and 1 respectively), not binary. However, the driver interprets these as bitfields: - BIT(0): R0 - BIT(1): R1 So valid values are: - 0 => no pull - 1 => enable R0 - 2 => enable R1 - 3 => enable R0 + R1 Using `<10>` is invalid as it exceeds the accepted range. It was likely intended as binary `0b10` (i.e., `2`), to enable R1 only. This patch replaces incorrect values with the correct ones and removes the leading zero from `<01>` to avoid confusion with bitfield notation. Signed-off-by: Julien Massot <julien.massot@collabora.com> --- arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
index dbdee604edab4318c1ba87b9594ce52282b0c405..bbed369db986f3f24aea470a9ad63a7c1e2cb3c9 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts@@ -318,19 +318,19 @@ pins_cmd_dat { <PINMUX_GPIO122__FUNC_MSDC0_CMD>; input-enable; drive-strength = <MTK_DRIVE_14mA>; - mediatek,pull-up-adv = <01>; + mediatek,pull-up-adv = <1>; }; pins_clk { pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>; drive-strength = <MTK_DRIVE_14mA>; - mediatek,pull-down-adv = <10>; + mediatek,pull-down-adv = <2>; }; pins_rst { pinmux = <PINMUX_GPIO133__FUNC_MSDC0_RSTB>; drive-strength = <MTK_DRIVE_14mA>; - mediatek,pull-down-adv = <01>; + mediatek,pull-down-adv = <1>; }; };
@@ -347,25 +347,25 @@ pins_cmd_dat { <PINMUX_GPIO122__FUNC_MSDC0_CMD>; input-enable; drive-strength = <MTK_DRIVE_14mA>; - mediatek,pull-up-adv = <01>; + mediatek,pull-up-adv = <1>; }; pins_clk { pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>; drive-strength = <MTK_DRIVE_14mA>; - mediatek,pull-down-adv = <10>; + mediatek,pull-down-adv = <2>; }; pins_ds { pinmux = <PINMUX_GPIO131__FUNC_MSDC0_DSL>; drive-strength = <MTK_DRIVE_14mA>; - mediatek,pull-down-adv = <10>; + mediatek,pull-down-adv = <2>; }; pins_rst { pinmux = <PINMUX_GPIO133__FUNC_MSDC0_RSTB>; drive-strength = <MTK_DRIVE_14mA>; - mediatek,pull-up-adv = <01>; + mediatek,pull-up-adv = <1>; }; };
@@ -377,13 +377,13 @@ pins_cmd_dat { <PINMUX_GPIO33__FUNC_MSDC1_DAT2>, <PINMUX_GPIO30__FUNC_MSDC1_DAT3>; input-enable; - mediatek,pull-up-adv = <10>; + mediatek,pull-up-adv = <2>; }; pins_clk { pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>; input-enable; - mediatek,pull-down-adv = <10>; + mediatek,pull-down-adv = <2>; }; pins_pmu {
@@ -401,13 +401,13 @@ pins_cmd_dat { <PINMUX_GPIO30__FUNC_MSDC1_DAT3>; drive-strength = <6>; input-enable; - mediatek,pull-up-adv = <10>; + mediatek,pull-up-adv = <2>; }; pins_clk { pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>; drive-strength = <8>; - mediatek,pull-down-adv = <10>; + mediatek,pull-down-adv = <2>; input-enable; }; };
--
2.50.1