Thread (38 messages) 38 messages, 5 authors, 2025-08-20

Re: [PATCH 9/9] arm64: dts: mediatek: mt8183-pumkin: Fix pull-down/up-adv values

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2025-08-04 07:59:25
Also in: linux-clk, linux-devicetree, linux-gpio, linux-mediatek, linux-sound, lkml

Il 01/08/25 13:18, Julien Massot ha scritto:
The properties `mediatek,pull-up-adv` and `mediatek,pull-down-adv`
were using incorrect values like `<10>` and `<01>`. These values
are parsed as decimal (10 and 1 respectively), not binary.

However, the driver interprets these as bitfields:
   - BIT(0): R0
   - BIT(1): R1

So valid values are:
   - 0 => no pull
   - 1 => enable R0
   - 2 => enable R1
   - 3 => enable R0 + R1

Using `<10>` is invalid as it exceeds the accepted range.
It was likely intended as binary `0b10` (i.e., `2`),
to enable R1 only.

This patch replaces incorrect values with the correct ones
and removes the leading zero from `<01>` to avoid confusion
with bitfield notation.

Signed-off-by: Julien Massot <julien.massot@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help