Re: [PATCH v3 14/62] KVM: SVM: Track AVIC tables as natively sized pointers, not "struct pages"
From: Naveen N Rao <naveen@kernel.org>
Date: 2025-06-17 15:10:18
Also in:
kvm, kvmarm, linux-iommu, lkml
On Wed, Jun 11, 2025 at 03:45:17PM -0700, Sean Christopherson wrote:
quoted hunk ↗ jump to hunk
@@ -277,8 +265,8 @@ static int avic_init_backing_page(struct kvm_vcpu*vcpu) return 0; } - BUILD_BUG_ON((AVIC_MAX_PHYSICAL_ID + 1) * sizeof(*table) > PAGE_SIZE || - (X2AVIC_MAX_PHYSICAL_ID + 1) * sizeof(*table) > PAGE_SIZE); + BUILD_BUG_ON((AVIC_MAX_PHYSICAL_ID + 1) * sizeof(new_entry) > PAGE_SIZE || + (X2AVIC_MAX_PHYSICAL_ID + 1) * sizeof(new_entry) > PAGE_SIZE);
Ah, you change to 'new_entry' here. Would be good to rename it to just 'entry', but that's a minor nit. Ignore my comment on the previous patch. For this patch: Acked-by: Naveen N Rao (AMD) <naveen@kernel.org> - Naveen