Re: [PATCH v3 02/62] KVM: arm64: WARN if unmapping vLPI fails
From: Marc Zyngier <maz@kernel.org>
Date: 2025-06-12 11:59:11
Also in:
kvm, kvmarm, linux-iommu, lkml
On Wed, 11 Jun 2025 23:45:05 +0100, Sean Christopherson [off-list ref] wrote:
WARN if unmapping a vLPI in kvm_vgic_v4_unset_forwarding() fails, as failure means an IRTE has likely been left in a bad state, i.e. IRQs won't go where they should.
I have no idea what an IRTE is. But not having an VLPI mapping for an interrupt at the point where we're tearing down the forwarding is pretty benign. IRQs *still* go where they should, and we don't lose anything. What it may mean is that userspace and the guest may have done things in the wrong order for KVM to accelerate interrupt delivery. That's silly, but also completely harmless. M. -- Without deviation from the norm, progress is not possible.