Re: [PATCH v2 1/4] dt-bindings: opp: adreno: Update regex of OPP entry

On Mon, Jun 16, 2025 at 10:18:24PM GMT, Akhil P Oommen wrote:

On 6/12/2025 4:59 PM, Krzysztof Kozlowski wrote:

quoted

On 11/06/2025 14:24, Akhil P Oommen wrote:

quoted

quoted

quoted

 
 patternProperties:
-  '^opp-[0-9]+$':
+  '^opp(-?[0-9]+)*$':

Not correct regex. You allow "opp", "opp1" and all other unusual
variants. Commit does not explain what problem you are solving, so I
have no clue what you want here, but for sure opp1 is wrong.

Just to confirm, would this be fine for the requirement I mentioned above?

"'^opp(-[0-9]+)*$'"

No, You did not solve half of the problems - still allows "opp" and
commit msg does not explain why "opp" is now correct. Describe the
actual problem and then write the regex solving it in specific way, not
causing other effects.

Gotcha. If we want to be super strict, the regex should be:
^opp(-[0-9]+){1,2}$

Yes, looks good.

Best regards,
Krzysztof