Re: [PATCH v2 4/4] arm64: dts: qcom: Add GPU support to X1P42100 SoC

On 6/11/2025 4:52 PM, Krzysztof Kozlowski wrote:

On 11/06/2025 13:15, Akhil P Oommen wrote:

quoted

+		opp-280000000 {
+			opp-hz = /bits/ 64 <280000000>;
+			opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D1>;
+			opp-peak-kBps = <2136719>;
+			qcom,opp-acd-level = <0xc82f5ffd>;
+			opp-supported-hw = <0x1f>;
+		};
+	};
+
 };
 
 &gpucc {

@@ -41,6 +150,13 @@ &pcie6a_phy {
 	compatible = "qcom,x1p42100-qmp-gen4x4-pcie-phy";
 };
 
+&qfprom {
+	gpu_speed_bin: gpu_speed_bin@119 {

No underscores. You need to align downstream code to upstream. See
coding style.

Ack.

-Akhil

Best regards,
Krzysztof