Re: [PATCH v2 0/4] Support for Adreno X1-45 GPU
From: Konrad Dybcio <hidden>
Date: 2025-06-14 18:42:59
Also in:
dri-devel, linux-arm-msm, linux-devicetree, linux-pm, lkml
On 6/12/25 11:19 PM, Akhil P Oommen wrote:
quoted hunk ↗ jump to hunk
On 6/12/2025 5:32 PM, Jens Glathe wrote:quoted
On 6/11/25 13:15, Akhil P Oommen wrote:quoted
Add support for X1-45 GPU found in X1P41200 chipset (8 cpu core version). X1-45 is a smaller version of X1-85 with lower core count and smaller memories. From UMD perspective, this is similar to "FD735" present in Mesa.Hi Akhil, when loading the driver (still without firmware files) I'm getting a speedbin warning: [ 3.318341] adreno 3d00000.gpu: [drm:a6xx_gpu_init [msm]] *ERROR* missing support for speed-bin: 233. Some OPPs may not be supported by hardware I've seen that there is a table for speed bins, this one is not there. Tested on a Lenovo ThinkBook 16 G7 QOY.Hi Jens, Could you please try the below patch?diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.cb/drivers/gpu/drm/msm/adreno/a6xx_catalog.c index 2db748ce7df5..7748f92919b8 100644--- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c@@ -1510,7 +1510,8 @@ static const struct adreno_info a7xx_gpus[] = { { 0, 0 }, { 294, 1 }, { 263, 2 }, - { 141, 3 }, + { 233, 3 }, + { 141, 4 }, ), } };With this, you should see 1107Mhz as the GPU Fmax.
I see your dt entry takes care of bins 0..=4.. this oversight worries me a bit - are these values above (post change) all in sync with what you entered into DT? I'm not saying they necessarily aren't, but I want to avoid inconsistencies Konrad