Re: [PATCH v6 06/25] iommufd/access: Allow access->ops to be NULL for internal use
From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2025-06-16 13:33:11
Also in:
linux-doc, linux-iommu, linux-kselftest, linux-patches, linux-tegra, lkml
On Sat, Jun 14, 2025 at 12:14:31AM -0700, Nicolin Chen wrote:
quoted hunk ↗ jump to hunk
@@ -1321,7 +1328,7 @@ int iommufd_access_pin_pages(struct iommufd_access *access, unsigned long iova, /* Driver's ops don't support pin_pages */ if (IS_ENABLED(CONFIG_IOMMUFD_TEST) && - WARN_ON(access->iova_alignment != PAGE_SIZE || !access->ops->unmap)) + WARN_ON(access->iova_alignment != PAGE_SIZE)) return -EINVAL;
I don't want to loose this check, continuing blocking mdevs is still important. Only the internal access should be able to use this mechanism. Otherwise: Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Jason