Hi Andy,

On Wed, 7 May 2025 18:02:40 +0300
Andy Shevchenko [off-list ref] wrote:

On Wed, May 07, 2025 at 09:12:48AM +0200, Herve Codina wrote:

quoted

Setting fwnode->dev is specific to fw_devlink.

In order to avoid having a direct 'fwnode->dev = dev;' in several
place in the kernel, introduce fw_devlink_set_device() helper to perform
this operation.  

Makes sense, can you also mark that field as __private? So sparse can catch
the abusers up.

I didn't know about __private tag and related ACCESS_PRIVATE().
Indeed, It makes perfect sense.

I will add it in next iteration.

Thanks for pointing out.

Best regards,
Hervé