Re: [PATCH v2 5/8] phy: phy-snps-eusb2: make repeater optional
From: Dmitry Baryshkov <hidden>
Date: 2025-03-19 11:08:48
Also in:
linux-arm-msm, linux-devicetree, linux-phy, linux-samsung-soc, lkml
On Sun, Feb 23, 2025 at 02:22:24PM +0200, Ivaylo Ivanov wrote:
Some platforms initialize their eUSB2 to USB repeater in the previous stage bootloader and leave it in a working state for linux. Make the repeater optional in order to allow for reusing that state until proper repeater drivers are introduced.
Generally "works as it is setup by the bootloader" is a very invalid justification. Please don't do that. We should not be depending on the way the bootlader sets up the devices, unless that _really_ makes sense.
quoted hunk ↗ jump to hunk
Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> --- drivers/phy/phy-snps-eusb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index 4e5914a76..dcc69c00a 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c@@ -461,7 +461,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) return dev_err_probe(dev, ret, "failed to get regulator supplies\n"); - phy->repeater = devm_of_phy_get_by_index(dev, np, 0); + phy->repeater = devm_of_phy_optional_get(dev, np, 0); if (IS_ERR(phy->repeater)) return dev_err_probe(dev, PTR_ERR(phy->repeater), "failed to get repeater\n");-- 2.43.0
-- With best wishes Dmitry