Re: [PATCH v2 2/8] dt-bindings: phy: snps-eusb2: add exynos2200 support
From: Dmitry Baryshkov <hidden>
Date: 2025-02-23 23:43:54
Also in:
linux-arm-msm, linux-devicetree, linux-phy, linux-samsung-soc, lkml
On Sun, Feb 23, 2025 at 02:22:21PM +0200, Ivaylo Ivanov wrote:
quoted hunk ↗ jump to hunk
Exynos 2200 makes use of the Synposys eUSB2 IP, so document it in the binding. Unlike the currently documented Qualcomm SoCs, it doesn't provide reset lines for reset control and uses more clocks. Signed-off-by: Ivaylo Ivanov <redacted> --- .../bindings/phy/snps,eusb2-phy.yaml | 64 +++++++++++++++++-- 1 file changed, 57 insertions(+), 7 deletions(-)diff --git a/Documentation/devicetree/bindings/phy/snps,eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/snps,eusb2-phy.yaml index 22c77968f..f4164db71 100644 --- a/Documentation/devicetree/bindings/phy/snps,eusb2-phy.yaml +++ b/Documentation/devicetree/bindings/phy/snps,eusb2-phy.yaml@@ -23,6 +23,7 @@ properties: - qcom,x1e80100-snps-eusb2-phy - const: qcom,sm8550-snps-eusb2-phy - const: qcom,sm8550-snps-eusb2-phy + - const: samsung,exynos2200-snps-eusb2-phy reg: maxItems: 1@@ -31,12 +32,12 @@ properties: const: 0 clocks: - items: - - description: ref + minItems: 1 + maxItems: 3 clock-names: - items: - - const: ref + minItems: 1 + maxItems: 3 resets: maxItems: 1@@ -58,11 +59,60 @@ required: - compatible - reg - "#phy-cells" - - clocks - - clock-names
Why? Clocks are required in both if clauses.
- vdd-supply - vdda12-supply - - resets + +allOf: + - if: + properties: + compatible: + contains: + enum: + - qcom,sm8550-snps-eusb2-phy + + then: + properties: + reg: + maxItems: 1 + + clocks: + items: + - description: ref + + clock-names: + items: + - const: ref + + required: + - clocks + - clock-names + - resets + + - if: + properties: + compatible: + contains: + enum: + - samsung,exynos2200-snps-eusb2-phy + + then: + properties: + + clocks: + items: + - description: Reference clock + - description: Bus (APB) clock + - description: Control clock + + clock-names: + items: + - const: ref + - const: bus + - const: ctrl + + required: + - clocks + - clock-names additionalProperties: false -- 2.43.0
-- With best wishes Dmitry