Thread (40 messages) 40 messages, 5 authors, 2025-03-06

Re: [PATCH v2 4/8] PCI: brcmstb: Fix error path upon call of regulator_bulk_get()

From: Florian Fainelli <florian.fainelli@broadcom.com>
Date: 2025-02-20 17:29:37
Also in: linux-pci, lkml


On 2/14/2025 9:39 AM, Jim Quinlan wrote:
If regulator_bulk_get() returns an error, no regulators are created and we
need to set their number to zero.  If we do not do this and the PCIe
link-up fails, regulator_bulk_free() will be invoked and effect a panic.

Also print out the error value, as we cannot return an error upwards as
Linux will WARN on an error from add_bus().

Fixes: 9e6be018b263 ("PCI: brcmstb: Enable child bus device regulators from DT")
Signed-off-by: Jim Quinlan <redacted>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help