Re: [PATCH v4 2/4] arm64: dts: morello: Add support for common functionalities
From: Vincenzo Frascino <vincenzo.frascino@arm.com>
Date: 2025-01-07 14:50:00
Also in:
linux-devicetree, lkml
From: Vincenzo Frascino <vincenzo.frascino@arm.com>
Date: 2025-01-07 14:50:00
Also in:
linux-devicetree, lkml
[...]
quoted
+ + soc_refclk85mhz: clock-85000000 { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <85000000>; + clock-output-names = "iofpga:aclk";If this is ACLK for the IOFPGA outside the SoC, why is it called soc_refclk85mhz? Not that it seems to be used in this patch series.
Good catch. Indeed, it is not used in this series and the name and placement are incorrect. I can either rename it and move it to the board file or remove it and add it again in future. [...]
quoted
+ + i2c0: i2c@1c0f0000 {The I2C controller lives in the IOFGPA on the board, not the SoC.quoted
+ compatible = "cdns,i2c-r1p14"; + reg = <0x0 0x1c0f0000 0x0 0x1000>; + interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&dpu_aclk>; + + #address-cells = <1>; + #size-cells = <0>; + + status = "disabled"; + + hdmi_tx: hdmi-transmitter@70 {The transmitter is a discrete chip on the board, not the SoC.
Agreed on both the points, please have a look at my reply to Rob.
Jess
[...] -- Regards, Vincenzo