Re: [PATCH v4 2/4] arm64: dts: morello: Add support for common functionalities
From: Rob Herring <robh@kernel.org>
Date: 2025-01-03 22:26:20
Also in:
linux-devicetree, lkml
On Fri, Jan 3, 2025 at 12:16 PM Vincenzo Frascino [off-list ref] wrote:
The Morello architecture is an experimental extension to Armv8.2-A, which extends the AArch64 state with the principles proposed in version 7 of the Capability Hardware Enhanced RISC Instructions (CHERI) ISA. The Morello Platform (soc) and the Fixed Virtual Platfom (fvp) share some functionalities that have conveniently been included in morello.dtsi to avoid duplication.
One more thing...
+ i2c0: i2c@1c0f0000 {
+ compatible = "cdns,i2c-r1p14";
+ reg = <0x0 0x1c0f0000 0x0 0x1000>;
+ interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&dpu_aclk>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ status = "disabled";
+
+ hdmi_tx: hdmi-transmitter@70 {
+ compatible = "nxp,tda998x";It is odd that you add this node here, but don't enable i2c. If this is shared with fvp, then enable i2c here. If it isn't, then move this to the soc/sdb .dts. I'd rather see the FVP dts now rather than later so we can review how you split things. It's a little odd not being soc.dtsi and board.dts, but that's fine I think.
+ reg = <0x70>;
+ video-ports = <0x234501>;
+ port {
+ tda998x_0_input: endpoint {
+ remote-endpoint = <&dp_pl0_out0>;
+ };
+ };
+ };
+ };