Re: [PATCH v2 04/11] phy: phy-rockchip-samsung-hdptx: Add support for eDP mode
From: Damon Ding <hidden>
Date: 2024-12-19 01:50:31
Also in:
dri-devel, linux-devicetree, linux-phy, linux-rockchip, lkml
Hi Heiko, On 2024/12/18 20:35, Heiko Stübner wrote:
Hi Damon, Am Montag, 16. Dezember 2024, 04:12:18 CET schrieb Damon Ding:quoted
Add basic support for RBR/HBR/HBR2 link rates, and the voltage swing and pre-emphasis configurations of each link rate have been verified according to the eDP 1.3 requirements. Signed-off-by: Damon Ding <redacted> --- Changes in v2: - Add the module author ---quoted
@@ -255,6 +364,19 @@ struct ropll_config { u8 cd_tx_ser_rate_sel; }; +struct tx_drv_ctrl { + u8 tx_drv_lvl_ctrl; + u8 tx_drv_post_lvl_ctrl; + u8 ana_tx_drv_idrv_idn_ctrl; + u8 ana_tx_drv_idrv_iup_ctrl; + u8 ana_tx_drv_accdrv_en; + u8 ana_tx_drv_accdrv_ctrl; + u8 tx_drv_pre_lvl_ctrl; + u8 ana_tx_jeq_en; + u8 tx_jeq_even_ctrl; + u8 tx_jeq_odd_ctrl; +}; + enum rk_hdptx_reset { RST_PHY = 0, RST_APB,not a full review (yet), but this part conflicts with commit f2dbca169790 ("phy: phy-rockchip-samsung-hdptx: Don't request RST_PHY/RST_ROPLL/RST_LCPLL") [0] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=f2dbca169790ea1e436ffdd9ef37d7c3a4401c46
I will update to the latest Kernel branch and fix this conflict in the next version. Best regards, Damon