Re: [PATCH v2 00/11] Add eDP support for RK3588
From: Damon Ding <hidden>
Date: 2024-12-17 02:47:54
Also in:
dri-devel, linux-devicetree, linux-phy, linux-rockchip, lkml
Hi Rob, On 2024/12/17 0:29, Rob Herring (Arm) wrote:
On Mon, 16 Dec 2024 11:12:14 +0800, Damon Ding wrote:quoted
These patchs have been tested with a 1536x2048p60 eDP panel on RK3588S EVB1 board, and HDMI 1080P/4K display also has been verified on RK3588 EVB1 board. Patch 1~3 are the RK3588 eDP support of Rockchip analogix_dp driver. Patch 4 is the eDP mode support of samsung hdptx phy driver. Patch 5~6 are the Rk3588 eDP support of Aanalogix DP driver. Add phy interfaces is to configure the HDMI/eDP TX Combo PHY. Patch 7~8 are the renaming of hdptxphy node. It is not only used by HDMI display but also for the eDP display. Patch 9 is the addition of RK3588 eDP0 node. Patch 10 is to enable the eDP0 display on RK3588S EVB1 board. Patch 11 is to add the eDP1 related nodes for RK3588 SoC. Damon Ding (11): drm/rockchip: analogix_dp: Use formalized struct definition for grf field dt-bindings: display: rockchip: analogix-dp: Add support for RK3588 drm/rockchip: analogix_dp: Add support for RK3588 phy: phy-rockchip-samsung-hdptx: Add support for eDP mode drm/bridge: analogix_dp: add support for RK3588 drm/bridge: analogix_dp: Add support for phy configuration. dt-bindings: display: rockchip: Fix label name of hdptxphy for RK3588 HDMI TX Controller arm64: dts: rockchip: Fix label name of hdptxphy for RK3588 arm64: dts: rockchip: Add eDP0 node for RK3588 arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board arm64: dts: rockchip: Add nodes related to eDP1 for RK3588 .../rockchip/rockchip,analogix-dp.yaml | 1 + .../rockchip/rockchip,rk3588-dw-hdmi-qp.yaml | 2 +- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 33 +- .../dts/rockchip/rk3588-coolpi-cm5-evb.dts | 2 +- .../rockchip/rk3588-coolpi-cm5-genbook.dts | 2 +- .../boot/dts/rockchip/rk3588-evb1-v10.dts | 2 +- .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 55 + .../rk3588-friendlyelec-cm3588-nas.dts | 2 +- .../arm64/boot/dts/rockchip/rk3588-jaguar.dts | 2 +- .../boot/dts/rockchip/rk3588-nanopc-t6.dtsi | 2 +- .../dts/rockchip/rk3588-orangepi-5-plus.dts | 2 +- .../boot/dts/rockchip/rk3588-rock-5b.dts | 2 +- .../boot/dts/rockchip/rk3588-tiger-haikou.dts | 2 +- .../boot/dts/rockchip/rk3588s-coolpi-4b.dts | 2 +- .../boot/dts/rockchip/rk3588s-evb1-v10.dts | 50 + .../dts/rockchip/rk3588s-indiedroid-nova.dts | 2 +- .../boot/dts/rockchip/rk3588s-nanopi-r6.dtsi | 2 +- .../boot/dts/rockchip/rk3588s-odroid-m2.dts | 2 +- .../boot/dts/rockchip/rk3588s-orangepi-5.dtsi | 2 +- .../boot/dts/rockchip/rk3588s-rock-5a.dts | 2 +- .../boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +- .../drm/bridge/analogix/analogix_dp_core.c | 5 + .../gpu/drm/bridge/analogix/analogix_dp_reg.c | 56 ++ .../gpu/drm/rockchip/analogix_dp-rockchip.c | 149 ++- .../phy/rockchip/phy-rockchip-samsung-hdptx.c | 937 +++++++++++++++++- include/drm/bridge/analogix_dp.h | 3 +- 26 files changed, 1223 insertions(+), 100 deletions(-) -- 2.34.1My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rk3588-coolpi-cm5-evb.dtb rockchip/rk3588-coolpi-cm5-genbook.dtb rockchip/rk3588-evb1-v10.dtb rockchip/rk3588-friendlyelec-cm3588-nas.dtb rockchip/rk3588-jaguar.dtb rockchip/rk3588-orangepi-5-plus.dtb rockchip/rk3588-rock-5b.dtb rockchip/rk3588-tiger-haikou.dtb rockchip/rk3588s-coolpi-4b.dtb rockchip/rk3588s-evb1-v10.dtb rockchip/rk3588s-indiedroid-nova.dtb rockchip/rk3588s-odroid-m2.dtb rockchip/rk3588s-rock-5a.dtb rockchip/rk3588s-rock-5c.dtb' for 20241216031225.3746-1-damon.ding@rock-chips.com: arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dtb: edp@fdec0000: resets: [[31, 469], [31, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dtb: edp@fdec0000: resets: [[28, 469], [28, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dtb: edp@fdec0000: Unevaluated properties are not allowed ('#sound-dai-cells', 'reset-names', 'resets' were unexpected) from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dtb: edp@fdec0000: resets: [[31, 469], [31, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb: edp@fdec0000: resets: [[31, 469], [31, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dtb: edp@fdec0000: resets: [[31, 469], [31, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dtb: edp@fdec0000: resets: [[31, 469], [31, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb: edp@fdec0000: resets: [[31, 469], [31, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dtb: edp@fdec0000: resets: [[31, 469], [31, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb: edp@fdec0000: resets: [[31, 469], [31, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dtb: edp@fded0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dtb: edp@fded0000: resets: [[31, 471], [31, 470]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dtb: edp@fded0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb: edp@fded0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb: edp@fded0000: resets: [[31, 471], [31, 470]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb: edp@fded0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dtb: edp@fded0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dtb: edp@fded0000: resets: [[31, 471], [31, 470]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dtb: edp@fded0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dtb: edp@fded0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dtb: edp@fded0000: resets: [[31, 471], [31, 470]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dtb: edp@fded0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dtb: edp@fded0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dtb: edp@fded0000: resets: [[31, 471], [31, 470]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dtb: edp@fded0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb: edp@fded0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb: edp@fded0000: resets: [[31, 471], [31, 470]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb: edp@fded0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-genbook.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-genbook.dtb: edp@fdec0000: resets: [[31, 469], [31, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-genbook.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dtb: edp@fdec0000: resets: [[31, 469], [31, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-odroid-m2.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-odroid-m2.dtb: edp@fdec0000: resets: [[31, 469], [31, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-odroid-m2.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dtb: edp@fdec0000: resets: [[31, 469], [31, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dtb: edp@fdec0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dtb: edp@fdec0000: resets: [[31, 469], [31, 468]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dtb: edp@fdec0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb: edp@fded0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb: edp@fded0000: resets: [[31, 471], [31, 470]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb: edp@fded0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-genbook.dtb: edp@fded0000: clock-names:2: 'grf' was expected from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-genbook.dtb: edp@fded0000: resets: [[31, 471], [31, 470]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-genbook.dtb: edp@fded0000: reset-names: ['dp', 'apb'] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml#
I found the same warnings when dt-schema was updated, and all of these will be fixed in the next version. Best regards, Damon