Re: [PATCH v2 10/11] arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board
From: Dmitry Baryshkov <hidden>
Date: 2024-12-16 09:06:08
Also in:
dri-devel, linux-devicetree, linux-phy, linux-rockchip, lkml
On Mon, Dec 16, 2024 at 11:12:24AM +0800, Damon Ding wrote:
quoted hunk ↗ jump to hunk
Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board: - Add edp-panel node - Set pinctrl of pwm12 for backlight - Enable edp0/hdptxphy0/vp2 Signed-off-by: Damon Ding <redacted> --- Changes in v2: - Remove brightness-levels and default-brightness-level properties in backlight node. - Add the detail DT changes to commit message. --- .../boot/dts/rockchip/rk3588s-evb1-v10.dts | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+)diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts index bc4077575beb..5c1ea25b6524 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts@@ -9,6 +9,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> #include <dt-bindings/pinctrl/rockchip.h> +#include <dt-bindings/soc/rockchip,vop2.h> #include <dt-bindings/usb/pd.h> #include "rk3588s.dtsi"@@ -120,6 +121,18 @@ backlight: backlight { pwms = <&pwm12 0 25000 0>; }; + edp_panel: edp-panel { + compatible = "lg,lp079qx1-sp0v";
Please use aux-bus and a generic "edp-panel" entry for newer platforms instead of declaring the panel on the platform bus. Placing eDP panels on the platform bus has been deprecated for quite a while.
+ backlight = <&backlight>;
+ power-supply = <&vcc3v3_lcd_edp>;
+
+ port {
+ panel_in_edp: endpoint {
+ remote-endpoint = <&edp_out_panel>;
+ };
+ };
+ };
+
combophy_avdd0v85: regulator-combophy-avdd0v85 {
compatible = "regulator-fixed";
regulator-name = "combophy_avdd0v85";-- With best wishes Dmitry