Re: [PATCH 3/5] spi: rockchip: Don't check for failed get_fifo_len()

Hello Mark,

On 2024-09-26 11:17, Mark Brown wrote:

On Thu, Sep 26, 2024 at 10:55:01AM +0200, Heiko Stuebner wrote:

quoted

Am Donnerstag, 26. September 2024, 10:38:14 CEST schrieb Dragan Simic:

quoted

Since commit 13a96935e6f6 ("spi: rockchip: Support 64-location deep FIFOs"),
function get_fifo_len() can no longer return zero, so delete the redundant
check for zero in function rockchip_spi_probe().

quoted

Didn't this topic come up in another recent patch too?

quoted

Anyway, having looked up the what the current get_fifo_len does,
the 0 case should never happen, as you describe, so

One of the people doing random cleanups posted the same patch which I
pushed back on since probe() isn't a hot path and it means if
get_fifo_len() changes again it could silently break things.

Thanks for the clarification, it makes sense to keep the check for
future proofing.  I'll drop this patch in the v2 of this series.