Thread (18 messages) 18 messages, 4 authors, 2024-10-01

Re: [PATCH 3/5] spi: rockchip: Don't check for failed get_fifo_len()

From: Heiko Stuebner <heiko@sntech.de>
Date: 2024-09-26 08:55:09
Also in: linux-rockchip, linux-spi, lkml

Am Donnerstag, 26. September 2024, 10:38:14 CEST schrieb Dragan Simic:
Since commit 13a96935e6f6 ("spi: rockchip: Support 64-location deep FIFOs"),
function get_fifo_len() can no longer return zero, so delete the redundant
check for zero in function rockchip_spi_probe().

Signed-off-by: Dragan Simic <redacted>
Didn't this topic come up in another recent patch too?

Anyway, having looked up the what the current get_fifo_len does,
the 0 case should never happen, as you describe, so

Reviewed-by: Heiko Stuebner <heiko@sntech.de>


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help