Re: [PATCH 3/5] spi: rockchip: Don't check for failed get_fifo_len()

Hello Heiko,

On 2024-09-26 10:55, Heiko Stuebner wrote:

Am Donnerstag, 26. September 2024, 10:38:14 CEST schrieb Dragan Simic:

quoted

Since commit 13a96935e6f6 ("spi: rockchip: Support 64-location deep 
FIFOs"),
function get_fifo_len() can no longer return zero, so delete the 
redundant
check for zero in function rockchip_spi_probe().

Signed-off-by: Dragan Simic <redacted>

Didn't this topic come up in another recent patch too?

Hmm, perhaps, but I'm unaware of that patch?  Maybe I missed it.

Anyway, having looked up the what the current get_fifo_len does,
the 0 case should never happen, as you describe, so

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Thanks.