On Sun, 08 Sep 2024, Krzysztof Kozlowski wrote:

On 07/09/2024 16:33, Junhao Xie wrote:

quoted

On 2024/9/7 16:44, Markus Elfring wrote:

quoted

…

quoted

+++ b/include/linux/mfd/photonicat-pmu.h

@@ -0,0 +1,86 @@

…

quoted

+#ifndef _PHOTONICAT_PMU_H
+#define _PHOTONICAT_PMU_H

…

I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus

Thanks for your suggestion, does this look better?
#ifndef MFD_PHOTONICAT_PMU_H
#define MFD_PHOTONICAT_PMU_H

Yes, this is better.

<form letter>
Feel free to ignore all comments from Markus, regardless whether the
suggestion is reasonable or not. This person is banned from LKML and
several maintainers ignore Markus' feedback, because it is just a waste
of time.
</form letter>

If you really _must_ do this, at least keep it factual.

To the best of my knowledge Markus is not banned from LKML.

-- 
Lee Jones [李琼斯]