[PATCH 0/9] Introduce Photonicat power management MCU driver · Junhao Xie <hidden> · 2024-09-06
[PATCH 1/9] mfd: Add driver for Photonicat power management MCU · Junhao Xie <hidden> · 2024-09-06
Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU · Krzysztof Kozlowski <krzk@kernel.org> · 2024-09-06
Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU · Junhao Xie <hidden> · 2024-09-06
Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU · Markus Elfring <hidden> · 2024-09-07
Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU · Junhao Xie <hidden> · 2024-09-07
Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU · Markus Elfring <hidden> · 2024-09-07
Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU · Junhao Xie <hidden> · 2024-09-07
Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU · Krzysztof Kozlowski <krzk@kernel.org> · 2024-09-08
Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU · Lee Jones <lee@kernel.org> · 2024-09-12
[PATCH 2/9] power: reset: add Photonicat PMU poweroff driver · Junhao Xie <hidden> · 2024-09-06
Re: [PATCH 2/9] power: reset: add Photonicat PMU poweroff driver · Krzysztof Kozlowski <krzk@kernel.org> · 2024-09-06
Re: [PATCH 2/9] power: reset: add Photonicat PMU poweroff driver · Junhao Xie <hidden> · 2024-09-06
[PATCH 3/9] watchdog: Add Photonicat PMU watchdog driver · Junhao Xie <hidden> · 2024-09-06
Re: [PATCH 3/9] watchdog: Add Photonicat PMU watchdog driver · Guenter Roeck <linux@roeck-us.net> · 2024-09-06
Re: [PATCH 3/9] watchdog: Add Photonicat PMU watchdog driver · Junhao Xie <hidden> · 2024-09-06
[PATCH 4/9] power: supply: photonicat-supply: Add Photonicat PMU battery and charger · Junhao Xie <hidden> · 2024-09-06
[PATCH 5/9] rtc: Add Photonicat PMU real-time clock · Junhao Xie <hidden> · 2024-09-06
[PATCH 6/9] hwmon: Add support for Photonicat PMU board temperature sensor · Junhao Xie <hidden> · 2024-09-06
Re: [PATCH 6/9] hwmon: Add support for Photonicat PMU board temperature sensor · Guenter Roeck <linux@roeck-us.net> · 2024-09-06
Re: [PATCH 6/9] hwmon: Add support for Photonicat PMU board temperature sensor · Junhao Xie <hidden> · 2024-09-06
Re: [PATCH 6/9] hwmon: Add support for Photonicat PMU board temperature sensor · Guenter Roeck <linux@roeck-us.net> · 2024-09-06
[PATCH 7/9] leds: add Photonicat PMU LED driver · Junhao Xie <hidden> · 2024-09-06
Re: [PATCH 7/9] leds: add Photonicat PMU LED driver · Lee Jones <lee@kernel.org> · 2024-10-02
Re: [PATCH 7/9] leds: add Photonicat PMU LED driver · Junhao Xie <hidden> · 2024-11-08
[PATCH 8/9] dt-bindings: Add documentation for Photonicat PMU · Junhao Xie <hidden> · 2024-09-06
Re: [PATCH 8/9] dt-bindings: Add documentation for Photonicat PMU · Krzysztof Kozlowski <krzk@kernel.org> · 2024-09-06
Re: [PATCH 8/9] dt-bindings: Add documentation for Photonicat PMU · Junhao Xie <hidden> · 2024-09-07
Re: [PATCH 8/9] dt-bindings: Add documentation for Photonicat PMU · Krzysztof Kozlowski <krzk@kernel.org> · 2024-09-08
[PATCH 9/9] arm64: dts: rockchip: add Photonicat PMU support for Ariaboard Photonicat · Junhao Xie <hidden> · 2024-09-06
Re: [PATCH 9/9] arm64: dts: rockchip: add Photonicat PMU support for Ariaboard Photonicat · Krzysztof Kozlowski <krzk@kernel.org> · 2024-09-06
Re: [PATCH 9/9] arm64: dts: rockchip: add Photonicat PMU support for Ariaboard Photonicat · Junhao Xie <hidden> · 2024-09-06
Re: [PATCH 0/9] Introduce Photonicat power management MCU driver · Krzysztof Kozlowski <krzk@kernel.org> · 2024-09-06
Re: [PATCH 0/9] Introduce Photonicat power management MCU driver · Junhao Xie <hidden> · 2024-09-06
Re: [PATCH 0/9] Introduce Photonicat power management MCU driver · Chukun Pan <hidden> · 2024-09-08
Re: [PATCH 0/9] Introduce Photonicat power management MCU driver · Junhao Xie <hidden> · 2024-09-11

Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU

From: Markus Elfring <hidden>
Date: 2024-09-07 08:45:01
Also in: linux-devicetree, linux-hwmon, linux-leds, linux-pm, linux-rockchip, linux-rtc, linux-watchdog, lkml

…

quoted hunk ↗ jump to hunk

+++ b/include/linux/mfd/photonicat-pmu.h

@@ -0,0 +1,86 @@

…

+#ifndef _PHOTONICAT_PMU_H
+#define _PHOTONICAT_PMU_H

…

I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help