Thread (14 messages) 14 messages, 2 authors, 2024-08-13

RE: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal platform

From: "Potthuri, Sai Krishna" <sai.krishna.potthuri@amd.com>
Date: 2024-08-13 16:02:05
Also in: linux-devicetree, linux-gpio, lkml

Hi Krzysztof,
-----Original Message-----
From: Krzysztof Kozlowski <redacted>
Sent: Tuesday, August 13, 2024 3:45 PM
To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com>; Linus Walleij
[off-list ref]; Simek, Michal [off-list ref]; Rob
Herring [off-list ref]; Krzysztof Kozlowski
[off-list ref]; Conor Dooley [off-list ref];
Buddhabhatti, Jay [off-list ref]; Kundanala, Praveen Teja
[off-list ref]; Greg Kroah-Hartman
[off-list ref]
Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
linux-gpio@vger.kernel.org; devicetree@vger.kernel.org;
saikrishna12468@gmail.com; git (AMD-Xilinx) [off-list ref]
Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal
platform

On 13/08/2024 07:40, Potthuri, Sai Krishna wrote:
quoted
quoted
sd1_wp_0_grp, sd1_wp_1_grp,
quoted
+                         ospi0_0_grp, ospi0_ss_0_grp, qspi0_0_grp,
qspi0_fbclk_0_grp, qspi0_ss_0_grp,
quoted
+                         test_clk_0_grp, test_scan_0_grp, tamper_trigger_0_grp]
+            maxItems: 78
You miss minItems... I have doubts this was really tested.
groups/pins are mentioned as required property.
Do we still need to define minItems?
These are two unrelated concepts. How many items can be listed at once in
each property?
In this case, minItem should be 1, my understanding is since property is
mentioned as required, minItem: 1 is an implicit consideration.
Please correct me if my understanding is wrong.

Regards
Sai Krishna
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help