Hi Krzysztof,

-----Original Message-----
From: Krzysztof Kozlowski <redacted>
Sent: Saturday, August 10, 2024 7:05 PM
To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com>; Linus Walleij
[off-list ref]; Simek, Michal [off-list ref]; Rob
Herring [off-list ref]; Krzysztof Kozlowski
[off-list ref]; Conor Dooley [off-list ref];
Buddhabhatti, Jay [off-list ref]; Kundanala, Praveen Teja
[off-list ref]; Greg Kroah-Hartman
[off-list ref]
Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
linux-gpio@vger.kernel.org; devicetree@vger.kernel.org;
saikrishna12468@gmail.com; git (AMD-Xilinx) [off-list ref]
Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal
platform

On 08/08/2024 07:53, Potthuri, Sai Krishna wrote:

quoted

quoted

quoted

 1 file changed, 398 insertions(+)

quoted

quoted

+      bias-pull-up: true
+
+      bias-pull-down: true
+
+      bias-disable: true
+
+      input-schmitt-enable: true
+
+      input-schmitt-disable: true
+
+      bias-high-impedance: true
+
+      low-power-enable: true
+
+      low-power-disable: true

Why do you need to copy all of these? Just switch to

unevaluatedProperties.

quoted

I tried with "unevaluatedProperties: false", it worked but by adding
this all the properties in the pincfg-node.yaml become valid for this
platform which is not true. Not all the properties in the pincfg-node.yaml

are supported in this platform.

quoted

So, is there any other way of representing this?

If they do not make any sense, then sure, you can keep it like this.
Drop the blank lines between each of these, so it will be compact.

Ok, will do it.

Also, do you agree with my comments which I replied in other thread?
Pasting those comments below for reference,

sd1_wp_0_grp, sd1_wp_1_grp,

quoted

+                         ospi0_0_grp, ospi0_ss_0_grp, qspi0_0_grp,

qspi0_fbclk_0_grp, qspi0_ss_0_grp,

quoted

+                         test_clk_0_grp, test_scan_0_grp, tamper_trigger_0_grp]
+            maxItems: 78

You miss minItems... I have doubts this was really tested.

groups/pins are mentioned as required property.
Do we still need to define minItems?

....

quoted

+
+      drive-strength:

drive-strength-microamp

In this case, values are in mA.
Do we still need to use drive-strength-microamp?

Regards
Sai Krishna