RE: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal platform
From: "Potthuri, Sai Krishna" <sai.krishna.potthuri@amd.com>
Date: 2024-08-08 05:53:45
Also in:
linux-devicetree, linux-gpio, lkml
Hi Krzysztof,
-----Original Message----- From: Krzysztof Kozlowski <redacted> Sent: Monday, August 5, 2024 3:38 PM To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com>; Linus Walleij [off-list ref]; Simek, Michal [off-list ref]; Rob Herring [off-list ref]; Krzysztof Kozlowski [off-list ref]; Conor Dooley [off-list ref]; Buddhabhatti, Jay [off-list ref]; Kundanala, Praveen Teja [off-list ref]; Greg Kroah-Hartman [off-list ref] Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-gpio@vger.kernel.org; devicetree@vger.kernel.org; saikrishna12468@gmail.com; git (AMD-Xilinx) [off-list ref] Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal platform On 01/08/2024 14:00, Sai Krishna Potthuri wrote:quoted
Add Xilinx Versal compatible string and corresponding groups, function and pins properties to support pin controller features on Versal platform. Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> --- .../bindings/pinctrl/xlnx,versal-pinctrl.yaml | 398 ++++++++++++++++++ 1 file changed, 398 insertions(+)
quoted
+ bias-pull-up: true + + bias-pull-down: true + + bias-disable: true + + input-schmitt-enable: true + + input-schmitt-disable: true + + bias-high-impedance: true + + low-power-enable: true + + low-power-disable: trueWhy do you need to copy all of these? Just switch to unevaluatedProperties.
I tried with "unevaluatedProperties: false", it worked but by adding this all the properties in the pincfg-node.yaml become valid for this platform which is not true. Not all the properties in the pincfg-node.yaml are supported in this platform. So, is there any other way of representing this? Regards Sai Krishna