Re: [PATCH 2/3] dt-bindings: Add power-domain header for RK3576 SoCs

On Sunday, 4 August 2024 05:56:39 EDT Krzysztof Kozlowski wrote:

On 02/08/2024 17:14, Detlev Casanova wrote:

quoted

From: Finley Xiao <redacted>

Define power domain IDs as described in the TRM.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patche
s.html#i-for-patch-submitters

quoted

Signed-off-by: Finley Xiao <redacted>
[reword]
Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
---

 include/dt-bindings/power/rk3576-power.h | 30 ++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 include/dt-bindings/power/rk3576-power.h

This is part of bindings.

quoted

diff --git a/include/dt-bindings/power/rk3576-power.h

b/include/dt-bindings/power/rk3576-power.h

Missing vendor prefix. This should be named after compatible.

Looks like all other rockchip power bindings use the include/dt-bindings/
power/rkXXXX.h format. Should I keep that way ?

quoted

new file mode 100644
index 0000000000000..cb33a32c1aed9

--- /dev/null
+++ b/include/dt-bindings/power/rk3576-power.h

@@ -0,0 +1,30 @@
+/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */

Weird license.

Best regards,
Krzysztof