Re: [PATCH 3/3] soc: rockchip: power-domain: Add power domain support for rk3576
From: Heiko Stübner <heiko@sntech.de>
Date: 2024-08-05 09:36:52
Also in:
linux-devicetree, linux-pm, linux-rockchip, lkml
Hi Detlev, Am Freitag, 2. August 2024, 17:15:00 CEST schrieb Detlev Casanova:
From: Finley Xiao <redacted>
with the power-domains now living somewhere else, the patch will need a different subject I think.
This driver is modified to support RK3576 SoCs and lists the power domains. Signed-off-by: Finley Xiao <redacted> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
quoted hunk ↗ jump to hunk
@@ -552,7 +574,10 @@ static int rockchip_pd_power(struct rockchip_pm_domain *pd, bool power_on) /* if powering up, leave idle mode */ rockchip_pmu_set_idle_request(pd, false); - rockchip_pmu_restore_qos(pd); + if (pd->info->delay_us) + udelay(pd->info->delay_us); + else + rockchip_pmu_restore_qos(pd);
the whole delay thing needs its own patch please. I.e. you're changing the inner workings of the driver here by not handling the qos settings and just waiting for a specific time. So I expect a lot more explanation on why that is the case and needed instead of it just happening when adding the soc-specific pieces. Does the rk3576 not have those qos settings and if so, why is there a delay necessary. This is not meant to disallow it, just that it needs its own commit with its own descriptive commit message :-) Heiko