Thread (23 messages) 23 messages, 4 authors, 2024-07-29

RE: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC CMU bindings

From: sunyeal.hong <hidden>
Date: 2024-07-25 07:14:57
Also in: linux-clk, linux-devicetree, linux-samsung-soc, lkml

Hello Krzysztof,
-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: Thursday, July 25, 2024 3:41 PM
To: sunyeal.hong <redacted>; 'Rob Herring'
[off-list ref]
Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>; 'Chanwoo Choi'
[off-list ref]; 'Alim Akhtar' [off-list ref]; 'Michael
Turquette' [off-list ref]; 'Stephen Boyd' [off-list ref];
'Conor Dooley' [off-list ref]; linux-samsung-soc@vger.kernel.org;
linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC
CMU bindings

On 25/07/2024 08:37, Krzysztof Kozlowski wrote:
quoted
quoted
  then:
    properties:
      clocks:
        items:
          - description: External reference clock (38.4 MHz)
          - description: CMU_MISC NOC clock (from CMU_MISC)

      clock-names:
        items:
          - const: oscclk
          - const: noc

If there is anything I misunderstand, please guide me.
You did not address my questions at all instead just copied again the
same. It is not how it works.

I am not going to discuss like this.
And in case it is still unclear - just look at your bindings and DTS.
They say you have three clocks!

Best regards,
Krzysztof
Let me answer your questions first.
In the existing V4 patch, clock items were declared in if then for each block, so there was no problem.
If modified according to Rob's comment, problems may occur as the input clock is configured differently for each block.

I think it would be better to keep the bindings in v4 patch form like the existing exynos models.

Thanks for your comment.

Best regards,
Sunyeal


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help